Fix #439: split query vs. iterator apart. #487

tseaver · 2015-01-03T06:33:23Z

Split Query (abstract constraints) from excution/iteration (cursor, etc.)

Also, rip out the protobuf attributes: doing the ongoing bookkeeping on them was painful (and a bug magnet). Instead, build the protobuf when we need it (just before fetching data), using values from both the query and the iterator.

Fixes #439.

Type-checking the 'dataset' argument to 'Query' introduced a cycle.

… etc.) Also, rip out the protobuf attributes: doing the ongoing bookkeeping on them was painful (and a bug magnet). Instead, build the protobuf when we need it (just before fetching data), using values from both the query and the iterator. Fixes #439.

coveralls · 2015-01-03T06:35:28Z

Coverage remained the same when pulling 539c418 on tseaver:439-split_query_iterator into b79d862 on GoogleCloudPlatform:master.

gcloud/datastore/query.py


-    def with_cursor(self, start_cursor, end_cursor=None):
-        """Specifies the starting / ending positions in a query's result set.
+def _pb_from_query(query):


It will go away when #477 lands. See: https://github.com/tseaver/gcloud-python/commit/d74a02d93950e27b35f6e9fbbec217ce68874a2b#commitcomment-9141844.

coveralls · 2015-01-05T22:04:21Z

Coverage remained the same when pulling 4645b72 on tseaver:439-split_query_iterator into b79d862 on GoogleCloudPlatform:master.

See: https://github.com/tseaver/gcloud-python/commit/d74a02d93950e27b35f6e9fbbec217ce68874a2b#commitcomment-9141854.

coveralls · 2015-01-05T22:09:25Z

Coverage remained the same when pulling 72a9520 on tseaver:439-split_query_iterator into b79d862 on GoogleCloudPlatform:master.

Fix typo. See: #487 (comment) #487 (comment)

coveralls · 2015-01-05T22:15:18Z

Coverage remained the same when pulling 537e868 on tseaver:439-split_query_iterator into b79d862 on GoogleCloudPlatform:master.

See: #487 (comment).

coveralls · 2015-01-05T22:26:49Z

Coverage remained the same when pulling 704f115 on tseaver:439-split_query_iterator into b79d862 on GoogleCloudPlatform:master.

Also, remove other mentions of cloning queries on write.

coveralls · 2015-01-05T22:37:44Z

Coverage remained the same when pulling 2832ce5 on tseaver:439-split_query_iterator into b79d862 on GoogleCloudPlatform:master.

dhermes · 2015-01-05T22:40:40Z

Only thing left to resolve is the discussion of _Iterator's publicness? Am I missing something?

See: #487 (comment)

coveralls · 2015-01-06T00:57:49Z

Coverage remained the same when pulling 2516ff8 on tseaver:439-split_query_iterator into b79d862 on GoogleCloudPlatform:master.

dhermes · 2015-01-06T00:59:02Z

Great. LGTM. We are good to merge (unless anything comes to mind).

#466 likely needs to be re-done now? Also the absence of _clone makes it more difficult to do something like #466

We can discuss there.

Fix #439: split query vs. iterator apart.

dhermes · 2015-01-06T01:01:15Z

w00t! @tseaver Can you give #485 a look? I'll rebase the PRs in #477 and ping you.

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

…487)

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

* docs: Fix formatting of request arg in docstring chore: Update gapic-generator-python to v1.9.1 PiperOrigin-RevId: 518604533 Source-Link: googleapis/googleapis@8a085ae Source-Link: googleapis/googleapis-gen@b2ab4b0 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiYjJhYjRiMGEwYWUyOTA3ZTgxMmMyMDkxOThhNzRlMDg5OGFmY2IwNCJ9 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

tseaver added 4 commits January 2, 2015 20:11

Don't rely on 'Query.to_protobuf' to test connection.

50e7e10

Rip out 'dataset.query' factory.

9cfb5b0

Type-checking the 'dataset' argument to 'Query' introduced a cycle.

Accomodate regression tests to new query-iterator split.

539c418

dhermes reviewed Jan 3, 2015
View reviewed changes

gcloud/datastore/query.py

def with_cursor(self, start_cursor, end_cursor=None):

"""Specifies the starting / ending positions in a query's result set.

def _pb_from_query(query):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

(Temporarily) restore top-level dataset import.

4645b72

It will go away when #477 lands. See: https://github.com/tseaver/gcloud-python/commit/d74a02d93950e27b35f6e9fbbec217ce68874a2b#commitcomment-9141844.

Note discrepancy btwn protobuf spec and current implementation.

72a9520

See: https://github.com/tseaver/gcloud-python/commit/d74a02d93950e27b35f6e9fbbec217ce68874a2b#commitcomment-9141854.

Move helper function after class defs.

537e868

Fix typo. See: #487 (comment) #487 (comment)

tseaver added 2 commits January 5, 2015 17:19

Add coverage for out-of-bounds enum.

9c37ad8

See: #487 (comment).

Appease lint.

704f115

tseaver mentioned this pull request Jan 5, 2015

Add keys function to Query. #466

Closed

tseaver added 2 commits January 5, 2015 17:31

Typo.

0aeb691

Rip out 'Query.clone' method.

2832ce5

Also, remove other mentions of cloning queries on write.

Make query iterator class public.

2516ff8

See: #487 (comment)

tseaver added a commit that referenced this pull request Jan 6, 2015

Merge pull request #487 from tseaver/439-split_query_iterator

9142051

Fix #439: split query vs. iterator apart.

tseaver merged commit 9142051 into googleapis:master Jan 6, 2015

tseaver deleted the 439-split_query_iterator branch January 6, 2015 01:00

dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015

atulep pushed a commit that referenced this pull request Apr 3, 2023

chore(main): release 2.17.2 (#487)

01b9725

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore(main): release 2.17.2 (#487)

5e2371a

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

atulep pushed a commit that referenced this pull request Apr 6, 2023

chore(main): release 2.17.2 (#487)

453d039

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

atulep pushed a commit that referenced this pull request Apr 18, 2023

chore(main): release 2.17.2 (#487)

d5a37a4

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Aug 15, 2023

chore(deps): update dependency google-cloud-dialogflow-cx to v1.16.0 (#…

d5faeaa

…487)

vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023

chore(deps): update dependency pytest to v7.1.1 (#487)

922cf02

Co-authored-by: Anthonios Partheniou <partheniou@google.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(main): release 3.12.0 (#487)

f602d7a

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Sep 22, 2023

chore(main): release 5.0.2 (#487)

1ab4889

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

parthea pushed a commit that referenced this pull request Oct 22, 2023

chore(main): release 2.17.2 (#487)

4b6969a

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #439: split query vs. iterator apart. #487

Fix #439: split query vs. iterator apart. #487

tseaver commented Jan 3, 2015

coveralls commented Jan 3, 2015

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Jan 5, 2015

coveralls commented Jan 5, 2015

coveralls commented Jan 5, 2015

coveralls commented Jan 5, 2015

coveralls commented Jan 5, 2015

dhermes commented Jan 5, 2015

coveralls commented Jan 6, 2015

dhermes commented Jan 6, 2015

dhermes commented Jan 6, 2015

Fix #439: split query vs. iterator apart. #487

Fix #439: split query vs. iterator apart. #487

Conversation

tseaver commented Jan 3, 2015

coveralls commented Jan 3, 2015

This comment was marked as spam.

This comment was marked as spam.

coveralls commented Jan 5, 2015

coveralls commented Jan 5, 2015

coveralls commented Jan 5, 2015

coveralls commented Jan 5, 2015

coveralls commented Jan 5, 2015

dhermes commented Jan 5, 2015

coveralls commented Jan 6, 2015

dhermes commented Jan 6, 2015

dhermes commented Jan 6, 2015